Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/apis: move resmgr apis to pkg/apis/resmgr. #264

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

klihub
Copy link
Collaborator

@klihub klihub commented Feb 12, 2024

Notes:

Move resmgr API and types to pkg/apis/resmgr/v1alpha1, next to other generated APIs (currently config). This re-enables automatic updating/generation of these APIs and allows annotating the types for better CRD validation which is useful if we use them in our config CRDs.

Copy link
Collaborator

@askervin askervin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@klihub klihub force-pushed the fixes/move-resmgr-api branch from 9a3f750 to 3253dd0 Compare February 13, 2024 09:39
Move resmgr API and types to pkg/apis/resmgr/v1alpha1,
next to other generated APIs (currently config). This
allows annotating the types for better CRD validation
which is useful if we use them in our config CRDs.

Signed-off-by: Krisztian Litkey <[email protected]>
@klihub klihub force-pushed the fixes/move-resmgr-api branch from 3253dd0 to 67b52f1 Compare February 13, 2024 14:49
@klihub klihub merged commit 754b485 into containers:main Feb 13, 2024
2 checks passed
@klihub klihub deleted the fixes/move-resmgr-api branch February 13, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants